-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: extend slice acronym validator to not accept underscore #176
Feature: extend slice acronym validator to not accept underscore #176
Conversation
cddda76
to
da59b8c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
+ Coverage 80.75% 80.90% +0.14%
===========================================
Files 63 63
Lines 4848 4912 +64
===========================================
+ Hits 3915 3974 +59
- Misses 933 938 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@syphax-bouazzouni, I am looking at the code code changes and not seeing anything there that prevents the underscores in the slice acronyms:
In fact, the error message states that "_"s are allowed. |
da59b8c
to
c9e05b2
Compare
Hello @mdorf, I copied/reused this line from the ontology acronym validator code, and forget to remove the "_" from the error message. I updated the message to remove it for the error message |
fix ncbo/ontologies_api#87 (comment)