Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #209: HAR: use UTF-8, handle binary data #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stek29
Copy link

@stek29 stek29 commented May 6, 2024

see #209 for more info

notice: HAR originally only supports binary data in response content
however, most implementations handle it in postData too.

for example:
https://github.com/google/martian/blob/0f7e6797a04da412118541344bbe0d65945e24c9/har/har.go#L223-L234

see also:
https://indigo.re/posts/2020-10-09-har-is-clumsy.html

Copy link
Contributor

@CoreyD97 CoreyD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants