Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-vectorised option for rvs in StructDist #100

Closed
wants to merge 1 commit into from

Conversation

MercuryBench
Copy link
Contributor

For some cases (in certain more complicated conditional distributions), rvs cannot be sampled all at once, and might need to be looped over. Proposed bugfix for #99

For some cases (in certain more complicated conditional distributions), rvs cannot be sampled all at once, and might need to be looped over.
@nchopin
Copy link
Owner

nchopin commented Oct 27, 2024

Please read CONTRIBUTING.md first when you want to do pull requests to any repo. I am going to reject all your PR because they directly target master, and not experimental (or another branch if you propose breaking changes, e.g. different function signatures, etc.).

Just to give you some background on why I put these rules in places: the last pull request I had to deal with was a very small change in a notebook, so accepted it despite the fact it was targetting directly master. This small change made the documentation website inaccessible, and I spent one hour trying to clean up the mess. So strict "push to experimental" policy from now on.

Contents of CONTRIBUTING.md

Thanks a lot for contributing to particles!

Please don't send PR (pull requests) directly to the master branch; send them
instead:

  • to the experimental branch if your PR is a bug fix;

  • to a new branch if your PR adds functionality.

In fact, when you fork any git repository, it is good practice to switch to
another branch than master before making any change. In this way, your PRs will
be automatically sent to that branch.

In doubt, contact the maintainer: nicolas dot chopin at ensae dot fr

@nchopin nchopin closed this Oct 27, 2024
@MercuryBench
Copy link
Contributor Author

MercuryBench commented Oct 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants