Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust parser ordering to error out on invalid names #26

Closed
wants to merge 1 commit into from
Closed

Adjust parser ordering to error out on invalid names #26

wants to merge 1 commit into from

Commits on Feb 26, 2019

  1. Adjust parser ordering to error out on invalid names 

    See tianon/gosu@fd60171 and tianon/gosu@f87df69.

The basic problem is that an invalid name like `bogus` will quietly run as `root` instead of being denied entirely (which those test updates look for and this change is verified to fix).

I've run this updated implementation successfully against all of the test cases in https://github.com/tianon/gosu/blob/f87df69c868e19f7258b4facb7c2472d76d98dda/Dockerfile.test.
    @tianon
    tianon committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d153e48 View commit details
    Browse the repository at this point in the history