Multiple fixes #25
Merged
Multiple fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmbr3
commented
May 17, 2024
|
Callum, can you please sign your patches. |
Ah, I missed one EDIT: I presume you mean the Signed-off-by tag, they are already GPG signed |
gmbr3
force-pushed
the
RuntimeError
branch
3 times, most recently
from
12b6be4 to
585f575
Compare
CopyMemC cos CONST Src Reverts 6b9dae0 Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
gmbr3
force-pushed
the
RuntimeError
branch
3 times, most recently
from
1efd11e to
b486a2e
Compare
* Add efi_machine_type_name and gnu_efi_arch from fwupd-efi * Add gnu_efi_default_is_objcopy so downstreams know if the crt0 goes objcopy Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
I wondered why a patch didn't apply :( Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
Added the missing Signed-off-by tag |
|
Forgot to add Bug References |
Fixes ncroxon#9 Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
ncroxon
approved these changes
May 20, 2024
gmbr3
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9