Disable RELRO (Support LLD) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No point having PT_GNU_RELRO as ELF data won't exist when merging into PE32+ file Unbreaks lld usage which complains about linker script Fixes ncroxon#4
gmbr3
added a commit
to gmbr3/fwupd-efi
that referenced
this pull request
Apr 24, 2024
No point having PT_GNU_RELRO as ELF data won't exist when merging into PE32+ file Unbreaks lld usage which complains about linker script Copy of ncroxon/gnu-efi#5
|
I've tried this on the flatpak cross-build and get: ld: unrecognized option '-Wl,-z,relro,-z,now' |
Removing RELRO would break NOW aswell, I presume LD means you have conflicting options not that it doesn't know . Any idea where these options are coming from?? Flatpak defaults?? |
superm1
pushed a commit
to fwupd/fwupd-efi
that referenced
this pull request
Apr 24, 2024
No point having PT_GNU_RELRO as ELF data won't exist when merging into PE32+ file Unbreaks lld usage which complains about linker script Copy of ncroxon/gnu-efi#5
Yup, you're completely correct -- it's from /etc/flatpak-builder/defaults.json -- opting out of that and with your patch it builds wonderfully. Thanks! |
hughsie
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point having PT_GNU_RELRO as ELF data won't exist when merging into PE32+ file
Unbreaks lld usage which complains about linker script
Fixes #4