Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Permissions section #48

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add File Permissions section #48

merged 7 commits into from
Feb 20, 2024

Conversation

lhelms2
Copy link
Collaborator

@lhelms2 lhelms2 commented Feb 19, 2024

Added "File and Directory Permissions" section to File Management to tell users not to grant permissions to "others". Also added a warning to the beginning of the "Creating and Editing Files" section in File Management.

You can view it built in Read the Docs here: https://docs.ncsa.illinois.edu/systems/nightingale/en/proposed_changes/user_guide/file_mgmt.html

initial fill of warning message to users about "others" permissions.
testing out just having permissions be a separate section.
Merging others-warning into proposed_changes
@lhelms2
Copy link
Collaborator Author

lhelms2 commented Feb 19, 2024

@pmenstrom @wjackson-gh
Can you please take a look at this PR?
I'd like to merge after 12pm on Friday (2/23), assuming I've gotten at least one approving review by then.

Thank you,
Lillian

@pmenstrom
Copy link
Collaborator

pmenstrom commented Feb 19, 2024 via email

Copy link
Collaborator

@pmenstrom pmenstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wjackson-gh
Copy link
Collaborator

I agree, it looks great.

@lhelms2
Copy link
Collaborator Author

lhelms2 commented Feb 20, 2024

@wjackson-gh @pmenstrom thank you for such quick reviews! I'll get it merged today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants