Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path unescape the data return in the X-Object-Manifest header #168

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Path unescape the data return in the X-Object-Manifest header #168

merged 1 commit into from
Oct 6, 2021

Conversation

houtmanj
Copy link
Contributor

This fixes an rclone bug 5180 where openstack/swift returned
an url encoded path in the X-Object-Manifest header.

This then caused problems when resolving the segments.

@houtmanj
Path escape the data return in the X-Object-Manifest header
0d2780a 
This fixes an rclone bug 5180 where openstack/swift returned
an url encoded path in the X-Object-Manifest header.

This then caused problems when resolving the segments.
@houtmanj houtmanj mentioned this pull request Apr 16, 2021
Open
@houtmanj houtmanj changed the title Path escape the data return in the X-Object-Manifest header Path unescape the data return in the X-Object-Manifest header Apr 16, 2021
ncw
ncw reviewed Apr 17, 2021
View reviewed changes
Copy link
Owner

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

Can you put these in the commit messages

  • a link (URL) to the rclone issue
  • a link to the Swift docs with the changes

I note that if we are URL decoding X-Object-Manifest then we need to url encode it too which we need to do don't we?

ncw
ncw approved these changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay - I'll merge this now - thank you :-)

@ncw ncw merged commit f746922 into ncw:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houtmanj @ncw