Fixed double key presses on windows due to crossterm changes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sequence, key events were handled twice, one for key press and one for key release. This fixes the issue by ignoring events when the type is not a key press. See relevant issue on crossterm: crossterm-rs/crossterm#797
ndd7xv
approved these changes
Jul 30, 2023
Codecov Report
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to cargo install heh on windows, and all the key presses were handled as if they were duplicated, making it unusable.
I did some digging and found this issue on
crossterm:crossterm-rs/crossterm#797
Bascially, after the update to 0.26, on windows,
crosstermreports key releases in addition to key presses instead of only key presses.I changed the
handle_inputfunction inapp.rsto ignore key inputs other than presses, as recommended in the issue previously mentioned.This seems to solve the issue without having any adverse effects, but I've only tested on windows.