Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove el argument from callback handler and update prittier rules #142

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Remove el argument from callback handler and update prittier rules #142

merged 2 commits into from
Nov 11, 2019

Conversation

ndelvalle
Copy link
Owner

This PR is related to #137
This PR aims to avoid having Detached HTMLDiv Element caused by storing the html reference in variables.

@ndelvalle ndelvalle self-assigned this Nov 8, 2019
@ndelvalle
Copy link
Owner Author

@francescozaniol do you mind taking a look at it 🙂

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 72.131% when pulling 2e486e0 on v3 into 2ee1804 on master.

Repository owner deleted a comment from coveralls Nov 8, 2019
Repository owner deleted a comment from coveralls Nov 8, 2019
Repository owner deleted a comment from coveralls Nov 8, 2019
@ndelvalle ndelvalle requested review from monkeyWzr and removed request for monkeyWzr November 8, 2019 03:59
@ndelvalle ndelvalle merged commit 6e5adc3 into master Nov 11, 2019
@ndelvalle ndelvalle deleted the v3 branch November 11, 2019 04:51
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndelvalle ndelvalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelvalle @coveralls @francescozaniol