Remove redundant judgments #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I deleted the code `event.target! == el`. The reason is as follows: - For `path.indexOf(el)` If `el` is not in `event.path`，indicates that the click occurred outside `el` - For `!el.contains(event.target)` If `event.target` is not a descendant element of `el` or `el` itself，indicates that the click occurred outside `el` Therefore, the additional judgment of `event.target! == el` is not needed. (Forgive my English is not good enough 😂)
2 similar comments
|
Thanks for the contribution @baooab, for some external reasons the CI is failing, I'll merge and fix this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deleted the code
event.target! == el. The reason is as follows:path.indexOf(el)If
elis not inevent.path，indicates that the click occurred outsideel!el.contains(event.target)If
event.targetis not a descendant element ofelorelitself，indicates that the click occurred outsideelTherefore, the additional judgment of
event.target! == elis not needed.(Forgive my poor english 😂)