Fix/232 exclude iframes inside element from detectIframe mechanism #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported on #232 "faux clicks" on iframe buttons (common pattern in social media buttons and other iframe widgets that were inside binding element were wrongly triggering "click-outside" handler.
too many `console.logs`, colorized them with elements color for easier grasp 💅
ndelvalle
deleted the
fix/232-exlcude-iframes-inside-element-from-detect-iframe-mechanism
branch
|
@renatodeleao you rock 🙌🏻 |
|
@renatodeleao v-click-outside 3.1.1 published 🎉 |
|
Yeah 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #232,
Making
onFauxIframeClicka little bit smarter by checking if the iframe that triggered theblurevent is inside thev-click-outsideelement, preventinghandlerexecution in that case.