Support anonymous binding better #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelvalle
requested changes
May 2, 2019
lib/v-click-outside.js
Outdated
| const { events, handler, middleware, isActive } = processDirectiveArguments(value) | ||
|
|
||
| if (!isActive) { | ||
| removeInstance(el) | ||
| return | ||
| } | ||
|
|
||
| if (JSON.stringify(value) === JSON.stringify(oldValue)) { |
There was a problem hiding this comment.
Should we move this to be the first thing to be executed in the update method? Above isActive check and processDirectiveArguments?
There was a problem hiding this comment.
I think you are right. I modified that. Thank you!
|
Thanks for the contribution @monkeyWzr, I just had a small comment, let me know what you think 🙂 |
|
@ndelvalle It looks fine. Please publish to alpha tag so that I can help test it. |
ndelvalle
approved these changes
May 3, 2019
|
@monkeyWzr @trongthanh v-click-outside 2.1.2-0 published 🎉. Thanks for the contribution, let me know how the test goes @trongthanh :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support anonymous binding better. Skip unnecessary updates and make
removeEventListenerwork.#34