Feature enhancements to the resource routing tab #60

jcraitz · 2015-10-13T21:00:12Z

Hi all,
This is my first pull request, so please pardon my errors and feel free to critique. I work at NCSU Libraries and we added some features to the routing tab for individual resources. The short version is that you now will have the ability to delete steps and also to reassign steps to different groups. Note: these changes will only affect the current resource. The changes will not be saved as a workflow template and restarting the workflow, will reset it to the original template.

It's the end of the day, so I'm just going to throw this up here now for you to check out, and I can add notes tomorrow on some of the details involved in these new features.

I did most of this work a couple of months back, and only recently merged them in to the current version of CORAL. As a result, there may be a few things that I do in a deprecated manner. In particular I haven't had a chance to double check the way I did the database query or the resourcestepForm.js. If you have a moment, will someone please look over these. I'll try to find time tomorrow to go back over them.

Cheers,
Jason Raitz

…rding to the language used and internationalization functions moved to a separate file

…rces Updated this respository to add the new features

…tabase (latin1 to utf8)

benheet · 2015-10-15T20:20:04Z

@jcraitz Would you also have Yan sign up for a github account so that she can participate in the comment thread on this pull request too? Thank you.

jcraitz · 2015-10-16T20:14:07Z

Sorry for the delay.

Here are some screen shots to show how this ends up changing the routing tab.

2 new columns (pictured below):

Between the Title and group columns you can now see a small edit step link. I used an icon that was already in the project. Clicking this link brings up a modal to choose a new group with the option to assign all later steps to that same group.
There is now a Delete column at the end of the row. Before actually deleting this step, a confirmation dialog will appear.

Note: I know that the Committee would like to keep this table uncluttered. I feel that these two small icon-sized link columns are a minimal addition that give much needed resource-level flexibility to the routing tab.

The screenshots below show the modal dialog that appears when a user clicks on the edit step link.

This is the confirmation dialog that appears when a user clicks a delete step link.

Some points on logic and clarifications:

The big picture here is that we would like to use the currently available new resource workflows as templates. Once we've started a resource workflow, our new features allow users to modify the workflow by deleting steps or editing Groups for that specific resource. This allows the resource to be flexible since they're all special snowflakes. :-)
Currently, these workflow changes are not saved or archived anywhere other than the current resource. Consequently, if a user restarts the workflow or deletes a step, there is no way to bring back any changes made since the resource was created from the template.
If a step is deleted that later step(s) depended on, the later steps are started and their groups are notified.
If the deleted step is the only remaining active step, deleting it will complete the workflow.
Speaking briefly to the feedback we've received on our other project, we feel that this ability to alter resource workflows in place, independent of similar workflows, is really valuable and can coexist with the proposed option to choose a new template when restarting a current workflow. We really like that idea BTW.

Ideas for future work:

Custom message for reassignments. As the code is written, when a step is reassigned, there is a new reassignment email sent to the new step group. Users have pointed out that this can be confusing for the ones getting the reassignment, as they're not always given any context. To avoid a separate email from the previous group, we propose that a temporary message input is added to the modal to be included in the reassignment email. There is no reason for this note to be saved anywhere, it is merely to give the new group some context on why they now have a new step to complete.
Adding new steps. Since we can now delete steps, it would be reasonable for later work to add in the complimentary ability to create new steps on the fly.
Archiving altered workflows. This pull request only changes the routing workflow for the current resource. As such, these changes are only visible for the current process. If the resource is deleted or restarted, then these changes disappear. Looking to the proposed feature that would give users new template options when restarting a workflow, it seems reasonable to be able to save a current workflow as a new template. Separately, it might also be valuable to users to archive a modified workflow for record keeping.

…yet tested.

…source' to 'instanceof mysqli_result'

Conflicts: admin/classes/common/DBService.php js/admin.js

Issue42 (translation)

Conflicts: admin.php sendAlerts.php

xsong9 · 2016-01-15T16:25:24Z

Can Steering Committee review the pull request and let us know if you have any question? Thanks!
--Yan

xsong9 · 2016-01-21T20:50:11Z

Ben, yes, we've been using the enhancement in production since last summer. Beside monograph unit, our serials unit have been using it for our new order workflows. We are very pleased with the enhancements. Let me know if you have more question.

Issues and Downtime Feature

PaulPoulain · 2016-03-10T12:39:35Z

This PR has conflicts, so I can't move it to the new merged repo. Please resubmit a mergeable PR, and I'll move it to https://github.com/Coral-erm/Coral

xsong9 · 2016-03-10T14:03:46Z

We'll work on it asap. What's your timeline for merging our pull request?

Thanks!
Yan

On Thu, Mar 10, 2016 at 7:39 AM, Paul Poulain notifications@github.com
wrote:

This PR has conflicts, so I can't move it to the new merged repo. Please
resubmit a mergeable PR, and I'll move it to
https://github.com/Coral-erm/Coral

—
Reply to this email directly or view it on GitHub
#60 (comment).

Xiaoyan Song

E-Resource Librarian
North Carolina State University Libraries
xsong9@ncsu.edu
(919)515-5742

xsong9 · 2016-03-10T17:06:09Z

Hi Paul,

Jason Raiz from our IT department is working on the update now. I'm cc'ing
him here in cause he has any question.

Thanks,
Yan

On Thu, Mar 10, 2016 at 7:39 AM, Paul Poulain notifications@github.com
wrote:

This PR has conflicts, so I can't move it to the new merged repo. Please
resubmit a mergeable PR, and I'll move it to
https://github.com/Coral-erm/Coral

—
Reply to this email directly or view it on GitHub
#60 (comment).

Xiaoyan Song

E-Resource Librarian
North Carolina State University Libraries
xsong9@ncsu.edu
(919)515-5742

# Conflicts: # ajax_htmldata/getRoutingDetails.php

jcraitz · 2016-03-11T20:33:38Z

I'm still testing this last commit. Feel free to point out anything wrong that you see.

PaulPoulain · 2016-03-14T08:08:32Z

Le 10/03/2016 15:03, xsong9 a écrit :

We'll work on it asap. What's your timeline for merging our pull request?
I have no timeline, I'll merge it when it's done.
The only problem if it's too long, being that patches could be merged on
the merged-repo, and this #60 wouldn't apply anymore.
So the sooner the better (less risk) !

Thanks!
Yan

Paul Poulain, Associé-gérant / co-owner
BibLibre, Services en logiciels libres pour les bibliothèques
BibLibre, Open Source software and services for libraries

xsong9 · 2016-04-04T19:50:20Z

I don't see #60 in the merged pull request list here:
https://github.com/Coral-erm/Coral/issues

It looks like all conflicts have been resolved. Has this been merged yet? If not, what's the timeline for merging this? Thanks!

PaulPoulain · 2016-04-06T12:13:11Z

PR ported to the unique repository & merged here : coral-erm/coral#13

Note that there was a missing _() on a javascript string that was needed for translation

Cesarfr added 30 commits April 3, 2015 14:49

Translation index.php et dependencies

d784906

Translate admin.php and dependencies

79e8995

Translate ajax_forms.php and update cataloging_edit.php

8e04df3

Translate ajax_htmldata.php

3409a8e

Finished translate ajax_htmldata.php

dd76bf3

Finished translate files PHP

c5c8399

Change dynamic of language with the dropdown

53c4fa6

Fixed date of cookie

991ecc5

Change dropdown 'Change Module' to text/CSS

23d0446

Translate update

d830070

Translate updated, change some strings

260cf3f

Translated dropdown

af85cc7

Translated summary.php and updated some strings in messages.po

183b94d

CSS fixed

a0e3550

Translated all files JavaScript with Gettext.js

fe8ed86

Updated translations and added some strings

e77ddcf

Changed variables names of function getCookie

93cf288

Translated data.js and jquery.datePicker.js to show the calendar acco…

33525a7

…rding to the language used and internationalization functions moved to a separate file

Translated default data in the database and translations updated

06fce6b

Merged ndlibersa/resources to update Cesarfr/resources

58b6aff

Translate of update started

fd319d0

Translated all files of recent update (v1.3)

9c676b0

Translate updated

86ebcb5

Translated missing line in resource.js to delete a resource

29a9124

Translated missing message in import.php

590fb2d

Added basic footer, including module version number

593bf3b

Merge remote-tracking branch 'ndlibersa/resources' into Cesarfr/resou…

0dd8ebe

…rces Updated this respository to add the new features

Translate updated

39a85e2

Translate updated to add new resource

0150a4e

Fixed issues to add new languages and added updated charset in the da…

3f7d254

…tabase (latin1 to utf8)

jsavell and others added 14 commits December 8, 2015 14:36

Merge branch 'master' into issues_feature_remastered

1b531b6

update version tweaks to installer

f204949

Update Readme

f0379a5

Validated forms in Administration tab

7b53fa5

Realigned code in admin.js

115fafd

Updated manuals and deleted commented line

58da2b7

mysql -> mysqli update. Should only impact database interaction. Not …

26ae17c

…yet tested.

fixed mistake in DBService::escapeString

09c38f6

Found critical bug produced with mysql->mysqli update, changed 'is_re…

9f97515

…source' to 'instanceof mysqli_result'

fixed references to 'this' in static context

d861516

Merge branch 'biblibre_issue42'

fcfc807

Conflicts: admin/classes/common/DBService.php js/admin.js

Merge pull request ndlibersa#65 from biblibre/issue42

46711fa

Issue42 (translation)

Merge branch 'master' into issues_feature_remastered

a1626ee

Conflicts: admin.php sendAlerts.php

utilize string translation wrapper

8162c0f

doug-hahn added 2 commits January 18, 2016 13:51

change update scripts to use UTF8

e08aa7a

Revise update and install

328fc5b

Merge pull request ndlibersa#66 from TAMULib/issues_feature_remastered

2c03c25

Issues and Downtime Feature

Merge branch 'jcraitzPullRequest60' into masterMerging

b203666

# Conflicts: # ajax_htmldata/getRoutingDetails.php

PaulPoulain mentioned this pull request Apr 6, 2016

resource Pr60, enhancements to the routing tab coral-erm/coral#13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature enhancements to the resource routing tab #60

Feature enhancements to the resource routing tab #60

jcraitz commented Oct 13, 2015

benheet commented Oct 15, 2015

jcraitz commented Oct 16, 2015

xsong9 commented Jan 15, 2016

xsong9 commented Jan 21, 2016

PaulPoulain commented Mar 10, 2016

xsong9 commented Mar 10, 2016

xsong9 commented Mar 10, 2016

jcraitz commented Mar 11, 2016

PaulPoulain commented Mar 14, 2016

xsong9 commented Apr 4, 2016

PaulPoulain commented Apr 6, 2016

Feature enhancements to the resource routing tab #60

Are you sure you want to change the base?

Feature enhancements to the resource routing tab #60

Conversation

jcraitz commented Oct 13, 2015

benheet commented Oct 15, 2015

jcraitz commented Oct 16, 2015

xsong9 commented Jan 15, 2016

xsong9 commented Jan 21, 2016

PaulPoulain commented Mar 10, 2016

xsong9 commented Mar 10, 2016

xsong9 commented Mar 10, 2016

jcraitz commented Mar 11, 2016

PaulPoulain commented Mar 14, 2016

xsong9 commented Apr 4, 2016

PaulPoulain commented Apr 6, 2016