Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect unused LANGUAGE BangPatterns #818

Closed
Ericson2314 opened this issue Jan 9, 2020 · 4 comments
Closed

Incorrect unused LANGUAGE BangPatterns #818

Ericson2314 opened this issue Jan 9, 2020 · 4 comments

Comments

@Ericson2314
Copy link

reflex-frp/reflex#382 and https://travis-ci.org/reflex-frp/reflex/jobs/634902715?utm_medium=notification&utm_source=github_status we have a wrong suggestion:

linting file src/Data/WeakBag.hs... /tmp/dist-test.jn5k/reflex-0.6.3/src/Data/WeakBag.hs:1:1: Warning: Unused LANGUAGE pragma

Found:

  {-# LANGUAGE BangPatterns #-}

Perhaps you should remove it.

1 hint

Bang patterns are used and removing them causes an build failure. 2.2.2 works, 2.2.6 doesn't, and I am in the process of testing other versions.

@Ericson2314
Copy link
Author

2.2.5 works, it's a fresh regression.

@ndmitchell
Copy link
Owner

Thanks for reporting! The extension stuff got rewritten in 2.2.6, which will be the cause. It doesn't spot let !x = 1 in 1. I'm working on fixing, but it's somewhat subtle, so going to have to finish this off tonight.

@ndmitchell
Copy link
Owner

Thanks, fixed it. HLint 2.2.7 now out with the fix included.

@Ericson2314
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants