-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added E.ON HUNGARY specification #134
Conversation
@ndokter Can you take a look at this pls? |
I would add a test like https://github.com/balazs92117/dsmr_parser/blob/eff0a5e1fc7065af902084e356fe6208fb563482/test/test_parse_v5.py maybe called test_parse_v5_hungary.py Where we can validate that a complete eon/hungary telegram parsees into all expected values |
@ndokter |
Thanks for your work, i will make a new build soon Edit: oh the tests broke, will look later |
Thank you! :) |
Hi im sorry i've had to revert the change for now. I noticed after merging that tests are breaking due to the belgium keys conflicting. After looking at it i think this is a more general issue that needs to be solved. Maybe these need to be renamed to a more general key or something else needs to be thought of for Or instead of that translation dict, use something more extensive than these key/values:
Maybe the translation value could be added there as well (using a new object). So in this case we could add 'P1_MESSAGE_HEADER' there. Could be an object or another nested dict:
Do you know what i mean? What do you think? |
I have added new specification for E.ON service provider of Hungary.
Unfortunately the #80 issue is still exists, so I modified the clients/socket_.py
Until the service provider does not send a "normal" message instead of
?
signs, we can't further test the issue.