SourceData Inspector #151
Merged
SourceData Inspector #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
added
Model
johannes-wolf
force-pushed
the
sourcedata-inspector
branch
2 times, most recently
from
f8de129
to
c4a2f80
Compare
johannes-wolf
force-pushed
the
sourcedata-inspector
branch
from
c4a2f80
to
1003337
Compare
johannes-wolf
force-pushed
the
sourcedata-inspector
branch
from
1003337
to
34e528a
Compare
johannes-wolf
force-pushed
the
sourcedata-inspector
branch
from
cd8973e
to
b973613
Compare
josephbirkner
approved these changes
Aug 26, 2024
johannes-wolf
force-pushed
the
sourcedata-inspector
branch
from
58e4ddc
to
5edecaf
Compare
Waguramu
reviewed
Aug 27, 2024
| @Pipe({ | ||
| name: 'highlight' | ||
| }) | ||
| export class HighlightSearch implements PipeTransform { |
There was a problem hiding this comment.
The name is a bit unclear since we only use this for tree data filtering but not with any search options. Should be either more generic or more precise.
There was a problem hiding this comment.
Do you have an idea? Maybe HighlightMatchingString?
| }) | ||
| export class InspectionPanelComponent implements OnInit { | ||
| export class InspectionPanelComponent implements OnInit |
There was a problem hiding this comment.
Should probably become RightPanelComponent
| return fetch.go() | ||
| .then(_ => { | ||
| if (!layer) | ||
| throw new Error(`Error loading layer.`); |
There was a problem hiding this comment.
Could add more information to the error message. Maybe IDs?
| .resizable-container-expanded { | ||
| height: calc(100vh - 3em);; | ||
| styles: [ | ||
| `@layer erdblick { |
There was a problem hiding this comment.
Do we necessarily need layers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
thenand friendsUI Changes
Yet Missing & Bugs
The inspector title does not show the current featureInspecting source data does not get reflected in the windows URLSetting a column size for tree tables does not work at all, horizontal scrolling also does not work(won't fix)Listening for feature selection changes should (maybe) be moved out of the FeatureInspector(should be done separately)