Restore streaming output writes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ary
commented
May 14, 2023
9ary
force-pushed
the
streaming_output
branch
3 times, most recently
from
0950575 to
7694466
Compare
During the upgrade from image 0.23 to 0.24, `ImageBuffer::write_to()` was changed to require a seekable writer. This doesn't work when writing to stdout, so we were forced to buffer the output before writing it out in one go. It turns out that most individual encoders don't actually require seeking, and neither of the two we use does. Restore streaming behavior by invoking encoders directly. See: image-rs/image#1922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the upgrade from image 0.23 to 0.24,
ImageBuffer::write_to()was changed to require a seekable writer.This doesn't work when writing to stdout, so we were forced to buffer the output before writing it out in one go.
It turns out that most individual encoders don't actually require seeking, and neither of the two we use does.
Restore streaming behavior by invoking encoders directly.
See: image-rs/image#1922
This still requires testing.