fresher GHA workflows #73
Conversation
| _R_CHECK_TESTS_NLINES_: 0 | ||
|
|
||
| steps: | ||
| - name: Configure git |
There was a problem hiding this comment.
Why was this step needed? Should I add it back?
There was a problem hiding this comment.
Some issue with line endings on windows (\r\n stuff), and setting this git config would make it just be \n. This was important because some tests comparing against recorded mocks would fail otherwise. But maybe the default has been fixed? Tests seem to pass without it right?
There was a problem hiding this comment.
Yes all green but I can add it back with a comment if you prefer.
There was a problem hiding this comment.
Nah, we should delete if it's no longer needed.
.github/workflows/R-CMD-check.yaml
Outdated
| - {os: windows-latest, r: 'release'} | ||
| # Use 3.6 to trigger usage of RTools35 |
There was a problem hiding this comment.
Do you think we need to mess with rtools35 here? There's no compiled code.
There was a problem hiding this comment.
I've now removed it.
Fix #72