feat(vote credit): add card, modal and row components #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stee1house
approved these changes
May 3, 2022
| daoName: dao.name || dao.id, | ||
| daoFunds: dao.totalDaoFunds, | ||
| }); | ||
| }, [dao.id, dao.name, dao.totalDaoFunds, showModal]); |
There was a problem hiding this comment.
Is there a reason not to destruct it and use id, name, etc... We are duplicating dao all the time.
| capitalize | ||
| className={styles.confirmButton} | ||
| variant="secondary" | ||
| onClick={() => onClose()} |
There was a problem hiding this comment.
Can we just pass onClose?
| Cancel | ||
| </Button> | ||
| <Button capitalize type="submit" className={styles.confirmButton}> | ||
| Submit |
There was a problem hiding this comment.
Should we leave some comment to remember about localisation? Maybe we should introduce some TODO at the top of the unlocalised files?
Comment on lines
+30
to
+32
| (async () => { | ||
| await getDaosList(); | ||
| })(); |
There was a problem hiding this comment.
Is there sense to wait till we get daos? Will we face some "race condition" if we remove await?
Comment on lines
+68
to
+69
| const publicKey = await nearService?.getPublicKey(); | ||
| const signature = await nearService?.getSignature(); |
There was a problem hiding this comment.
We have a getPublicKeyAndSignature method to get both)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.