Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multi Token Standard Contract [NEP] #245
feat: Multi Token Standard Contract [NEP] #245
Changes from 107 commits
e01a2fc
d13899f
e5c00d9
f1609fc
f384184
d744486
987eb81
4390c5c
c059657
6a258f8
4af4107
fa4cd9d
4c821ae
3ea9de1
85643b2
20c3ad6
36ada8c
a41e551
677cc74
f5d7631
caee79b
96f6188
08f0adc
3519b34
567dfe6
d2501f2
8dafe7c
5be2439
6697f42
eb0b7da
c090e46
a2ce801
90d5605
ddda893
9ae02d7
00bb5cf
65cbea1
95b4b01
a9d2afc
97f29ce
15d87ff
7061c20
7c5210a
913f58c
133381a
9a53499
46ae3b3
6bae0ec
6d73586
9208acf
917894a
aa3f085
04f5a41
2e56a4d
799f5bc
0339e58
c148a83
d5e0752
90451e3
561ba59
77ada21
4a6c164
e583a5b
585dbc9
d1c58a3
bf162c5
b290fc8
08e244a
6fdf26c
9b4fc8f
42d0e3b
b29ddca
791e5ec
44ee2a9
35a610a
49a356e
23b8c0a
46365af
025d5e9
807aa0e
4d9a8a5
3849190
8dc2bc9
dc57e04
1adf7b6
37940cd
5422f18
e2a2385
f9c5c9d
6f32cd3
f1a91b9
d3c77b4
c8af57e
6c93dd1
cecb1a2
fce6f7d
7a1f8b2
9d9d00a
414fdcd
dcbb0ed
d030776
d413ca3
c8a856e
65af2d1
86de2f8
2568f90
c7c9d14
763b7d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in all other logs:
These arrays should be the same length. Users could mess that up.
I'd prefer to have 1 array of jsons, something like
But I guess it's too wordy.
Maybe we can create a third idea of how to work with that in a more elegant way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative could be a couple of the data. I think that's maybe harder to communicate though.
MtMintLog {
owner_id: string
tokens: [ ["1","5"], ["awesome","10"]]
}
I think in terms of user familiarity with the restrictions, there's already a precedent set from the core implementations, They all have the same restrictions. These restrictions exist in the mirror standard 1155 as well . So users shouldn't be blindsided by it, and in most situations I think they could just pass the data along. 🤔