Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nep-393: add bool return to sbt_revoke_by_owner #510

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

robert-zaremba
Copy link
Contributor

In the reference implementation we return bool in the registry.sbt_revoke_by_owner to signal if the operation should continue or it's finished.

We forgot to push this update to the standard.

This update also makes the API consistent with sbt_recover and sbt_soul_transfer

@robert-zaremba robert-zaremba requested a review from a team as a code owner September 25, 2023 08:14
@render
Copy link

render bot commented Sep 25, 2023

@sczembor
Copy link

This change enhances the method to maintain consistency with other methods that may run a risk of running out of gas and require repeated execution. Consequently, it eliminates the necessity for an extra view call to verify the completion status of the revocation process.

Copy link

@KazanderDad KazanderDad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds a boolean to signal if the operation is finished, which ensures consistency with other methods that may run a risk of running out of gas and require repeated execution. If the result is false then the method should be called again until true is returned. This also eliminates the necessity for an extra view call to verify the completion status of the revocation process.

@robert-zaremba robert-zaremba added WG-contract-standards Contract Standards Work Group should be accountable S-draft/needs-moderator-review A NEP in the DRAFT stage that needs a moderator review. A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. labels Sep 27, 2023
neps/nep-0393.md Outdated Show resolved Hide resolved
@frol frol merged commit 6eee9dc into master Oct 22, 2023
4 checks passed
@frol frol deleted the sbt-revoke-by-owner branch October 22, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. S-draft/needs-moderator-review A NEP in the DRAFT stage that needs a moderator review. WG-contract-standards Contract Standards Work Group should be accountable
Projects
Status: APPROVED NEPs
Development

Successfully merging this pull request may close these issues.

4 participants