Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fungible token to 0.2.0 #80

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Update fungible token to 0.2.0 #80

merged 5 commits into from
Jun 5, 2020

Conversation

evgenykuzyakov
Copy link
Contributor

@evgenykuzyakov evgenykuzyakov commented Jun 4, 2020 •
edited
Loading

Fixes: near/core-contracts#47
Fixes: near/core-contracts#49

Changelog 0.2.0

  • Introduce storage deposits. Make every method payable. Require caller to attach enough deposit to cover potential storage increase. See core-contracts/#47
  • Replace set_allowance with inc_allowance and dec_allowance to address the issue of allowance front-running. See core-contracts/#49
  • Validate owner_id account ID. See core-contracts/#54
  • Enforce that the new_owner_id is different from the current owner_id for transfer. See core-contracts/#55

@render
Copy link

render bot commented Jun 4, 2020

Your Render PR Server URL is https://nomicon-pr-80.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brcjtf8951c3kkk1nfvg.

@render
Copy link

render bot commented Jun 4, 2020

Your Render PR Server at https://nomicon-pr-80.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brcjtf8951c3kkk1nfvg.

@janedegtiareva
Copy link

Do you mind posting a link to the documentation on what is payable for the folks who are not familiar with it?

@evgenykuzyakov
Copy link
Contributor Author

Do you mind posting a link to the documentation on what is payable for the folks who are not familiar with it?

Good question. I should clarify it in the standard. Payable methods explained here in the README for near-sdk https://github.com/near/near-sdk-rs/blob/master/README.md

@render
Copy link

render bot commented Jun 5, 2020

Your Render PR Server at https://nomicon-pr-80.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brcjtf8951c3kkk1nfvg.

Apply suggestions from code review
ead32cc 
Co-authored-by: Willem Wyndham <willem@cs.umd.edu>
@render
Copy link

render bot commented Jun 5, 2020

Your Render PR Server at https://nomicon-pr-80.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brcjtf8951c3kkk1nfvg.

@render
Copy link

render bot commented Jun 5, 2020

Your Render PR Server at https://nomicon-pr-80.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brcjtf8951c3kkk1nfvg.

@evgenykuzyakov evgenykuzyakov merged commit 1b6997c into master Jun 5, 2020
@evgenykuzyakov evgenykuzyakov deleted the update-fungible-token-standard branch June 5, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

@lexfrl lexfrl Awaiting requested review from lexfrl

@janedegtiareva janedegtiareva Awaiting requested review from janedegtiareva

@behaviary behaviary Awaiting requested review from behaviary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowance Front-Running Storage Fees Can Lead to a Denial-of-Service Condition
3 participants
@evgenykuzyakov @janedegtiareva @willemneal