-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI embedding #31
Merged
Merged
ABI embedding #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2022
miraclx
force-pushed
the
miraclx/abi-embed
branch
from
August 22, 2022 10:14
845fa86
to
ae0ff83
Compare
miraclx
force-pushed
the
miraclx/abi-embed
branch
from
August 22, 2022 10:29
ae0ff83
to
b94667a
Compare
This was
linked to
issues
Aug 22, 2022
3 tasks
itegulov
reviewed
Aug 26, 2022
This was referenced Aug 26, 2022
Merged
itegulov
reviewed
Aug 29, 2022
itegulov
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #23.
Introduces the
cargo near build
subcommand with the--embed-abi
flag.Building without the
--embed-abi
flag is effectively analogous to the convention of using./build.sh
to build contracts.With the flag however,
cargo near
inspects the contract, generating ABI that describes the contract and thereafter, embeds it into the contract. Which can be returned by calling the view method__contract_abi
.Some numbers (compiling the
abi
example in sdk):Without embedding ABI
With embedded ABI
That's an increase of 1768 bytes (1.78% of the final binary).
Related: near/near-sdk-rs#893