use shared target folder for faster CI #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
commented
Aug 27, 2022
This was referenced Aug 28, 2022
itegulov
approved these changes
Aug 29, 2022
austinabell
approved these changes
Aug 29, 2022
miraclx
force-pushed
the
miraclx/inspect
branch
from
05f413f
to
3cf1db2
Compare
miraclx
force-pushed
the
miraclx/test-shared-cache
branch
from
332c428
to
2dd19c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #41
Supersedes #24.
Current integration tests generate isolated projects with distinct target folders despite compiling ~99% of the same artifacts.
Causing current CI runs to run upwards of an hour.
With this patch, CI completes in under 10 minutes.
Based on #35, because in my tests, leaving the codegen in caused inconsistent results,
didn't bother investigating why. https://github.com/near/cargo-near/runs/8050886022?check_suite_focus=trueI eventually looked into it. See #40 for an alternative that merges straight into the main branch.