Build contract before integration tests #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests depend on a built artifact, so they'll fail unless the `build:contract` command is ran manually before running integration tests. It's also error-prone as users might not realize that they have to rebuild manually before running integration tests, and they might get confused. Incidentally this change also fixes the e2e tests that were failing in master locally on a fresh checkout of the repository. Branched out from near#2013, otherwise tests are failing.
frol
approved these changes
Jun 26, 2023
|
Re-opening this PR to trigger CI |
gagdiez
approved these changes
Jun 27, 2023
agostbiro
added a commit
to agostbiro/hello-near-rust
that referenced
this pull request
Jun 28, 2023
The `test:integration` task depends on the `build:contract` task, but it's currently ran as part of the `test` task so if a user just runs `test:integration` it may fail or run with an outdated build. The same change was made in `create-near-app`: near/create-near-app#2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests depend on a built artifact, so they'll fail unless the
build:contractcommand is ran manually before running integration tests.It's also error-prone as users might not realize that they have to rebuild manually before running integration tests, and they might get confused.
Incidentally this change also fixes the e2e tests that were failing in master locally on a fresh checkout of the repository.
Branched out from #2013, otherwise tests are failing.