Optional Account ID in signin flow #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidM-D
approved these changes
Apr 22, 2023
| let user_recovery_pk = get_user_recovery_pk(internal_acc_id.clone()); | ||
| let user_recovery_sk = get_user_recovery_sk(internal_acc_id); | ||
| let new_public_key: PublicKey = request | ||
| .public_key | ||
| .parse() | ||
| .map_err(|e| AddKeyError::MalformedPublicKey(request.public_key, e))?; | ||
|
|
||
| let user_account_id: AccountId = match &request.near_account_id { |
There was a problem hiding this comment.
Should we handle the error case of it being a list of IDs with this controlling key?
There was a problem hiding this comment.
We are just taking the first one now. There will be no error.
Also, we are using recovery PK. Since we allow anly one acc per our internal (firebase) Id, thre should always be one account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MPC_RECOVERY_ACCOUNT_LOOKUP_URL to our cloud run (both prod/mainnet and dev/testnet).
Added unit test, Integration test will require a whole wallet server or some kind of mocked get_acc function. I think we should pospone this.