Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_acc_id_from_pk error handling #140

Merged
merged 3 commits into from
Apr 25, 2023
Merged

get_acc_id_from_pk error handling #140

merged 3 commits into from
Apr 25, 2023

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Apr 25, 2023 •
edited
Loading

Error handling for pk -> acc id

@volovyks volovyks requested review from itegulov and DavidM-D April 25, 2023 20:36
@volovyks volovyks marked this pull request as ready for review April 25, 2023 20:37
esaminu
esaminu approved these changes Apr 25, 2023
View reviewed changes
Copy link

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DavidM-D
DavidM-D approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@DavidM-D DavidM-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some fine error handling

ChaoticTempest
ChaoticTempest approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volovyks volovyks merged commit 8fcc264 into develop Apr 25, 2023
@itegulov itegulov deleted the serhii/get_acc_id_from_pk_error_handling branch July 20, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidM-D DavidM-D DavidM-D approved these changes

@ChaoticTempest ChaoticTempest ChaoticTempest approved these changes

@esaminu esaminu esaminu approved these changes

@itegulov itegulov Awaiting requested review from itegulov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@volovyks @esaminu @ChaoticTempest @DavidM-D