feat: add limited key option #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
force-pushed
the
daniyar/limited_key
branch
from
19fd627 to
395e0b1
Compare
itegulov
force-pushed
the
daniyar/limited_key
branch
from
395e0b1 to
6e44925
Compare
|
CI is failing to load relayer docker image. Looking into that. |
DavidM-D
approved these changes
Apr 27, 2023
| .into_iter() | ||
| .find(|ak| ak.public_key.to_string() != user_public_key) | ||
| .find(|ak| { |
There was a problem hiding this comment.
I'm a bit confused by this, why are we searching for both the FA and the LA key, then assuming we found the FA key?
There was a problem hiding this comment.
Because we are creating an account with FA Key A and LA Key B. FA Key C (recovery) is added on the serverside.
So, if we will get all 3 keys, remove FA A and LA B, it should be FA C.
volovyks
added a commit
that referenced
this pull request
Apr 27, 2023
* chore: clarify deploy guide (#151) * chore: pull relayer image from Github Container Registry (#152) * chore: fix logging (#154) * feat: add limited key option (#150) * add limited key support --------- Co-authored-by: David Millar-Durrant <dmillardurrant@gmail.com> Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com> --------- Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com> Co-authored-by: David Millar-Durrant <dmillardurrant@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.