Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make add_key accept CreateAccountOptions #156

Merged
merged 2 commits into from
Apr 28, 2023
Merged

feat: make add_key accept CreateAccountOptions #156

merged 2 commits into from
Apr 28, 2023

Conversation

itegulov
Copy link
Contributor

Apparently near-discovery needs add_key to support this API too

MaximusHaximus
MaximusHaximus approved these changes Apr 28, 2023
View reviewed changes
Copy link

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM :)

@itegulov itegulov merged commit 1ad71da into develop Apr 28, 2023
@itegulov itegulov deleted the daniyar/adjust-add-key-v2 branch April 28, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximusHaximus MaximusHaximus MaximusHaximus approved these changes

@volovyks volovyks Awaiting requested review from volovyks

@ChaoticTempest ChaoticTempest Awaiting requested review from ChaoticTempest

@DavidM-D DavidM-D Awaiting requested review from DavidM-D

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @MaximusHaximus