-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prometheus metrics #201
Conversation
Terraform Dev EnvironmentTerraform Format and Style 🖌
|
Terraform Feature Environment (dev-201)Terraform Initialization ⚙️
|
Hey, feature enviornment are already paying off, check out the metrics hands-on by going to https://mpc-recovery-leader-dev-201-7tk2cmmtcq-ue.a.run.app/metrics :) |
Not an expert here, but I would vote for better security. Who knows what can endup in our logs now. We can be more or less safe after the error handling refactorin. |
Terraform Feature Environment Destroy (dev-201)Terraform Initialization ⚙️
|
Relates to #183
This PR introduces basic Prometheus metrics for our HTTP endpoints (total request count, 4xx response count, 5xx response count, processing time). It exposes them under an unprotected
/metrics
endpoint. It is debatable whether Prometheus endpoints should be protected (they were originally designed to be available to the general public, but there are many arguments against this in the modern world). I think we should add an auth/encryption mechanism here to be on the safe side. If someone here is an expert on the topic please let yourself known :)