-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decouple secret management from terraform #300
Conversation
88f1d00
to
77920c7
Compare
Terraform Feature Environment (dev-300)Terraform Initialization ⚙️
|
Terraform Dev EnvironmentTerraform Format and Style 🖌
|
Merging this as I need this to deploy one of the partners in an hour, but feel free to review this. Will upstream to |
Terraform Feature Environment Destroy (dev-300)Terraform Initialization ⚙️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@DavidM-D after this is merged to develop we will need to set secrets (including Firebase app IDs) in Secret Manager directly. Not in Terraform.
* feat: decouple secret management from terraform (#300) * initial commit for internal LB * added working dynamic TF for ILBs * separate prod and dev infra * changed connector id for dev * removed dev workflow, updated prod workflow * reflected dev and prod env * updated directory of dev workflow * updated all workflow dev directories * removed odic variable * updated prod workflow to have selectable networks * added var.env back to fix pipeline * reverted credential selection * made SA dynamic again * reverted GHA workflows * added back jwt signer url * updated prod env to include OTLP data * added correct naming convention for LB stuff * added correct credential info * added correct credential info --------- Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com> Co-authored-by: kmaus-near <kody.maus.bluepisces@near.org> Co-authored-by: kmaus-near <109096383+kmaus-near@users.noreply.github.com>
WARNING: This PR is targeting
main
Apologies for the last minute changes, but the more I use terraform the less and less I like that we manage secrets through TF variables, it's even worse that we are planning to make our partners do the same (which mean they can't persist their
tfvars
file or ever share it with us for debugging). This PR makes so that all secret values are replaced with their secret ID counterparts (e.g.account_creator_sk
->account_creator_sk_secret_id
), which presumes that the secret already exists and is managed outside of terraform.This, against my initial concerns, does not create any complications for deploying feature envs as we can just safely share the secrets with
dev
enviornment and not store anything in git or even GHA.