new_acc load tests #325
Merged
new_acc load tests #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-325)Terraform Initialization ⚙️
|
itegulov
previously approved these changes
Oct 23, 2023
| @@ -1,3 +1,4 @@ | |||
| /target | |||
| .direnv | |||
| .DS_Store | |||
| tmp | |||
There was a problem hiding this comment.
Out of scope for this PR, but I didn't realize in the initial PR that you are creating tmp under the local directory. We should be using /tmp instead, tempfile is usually useful for that.
There was a problem hiding this comment.
Nice! I will invest time into this if the current relayer setup remains permanent.
load-tests/Cargo.toml
Outdated
| near-crypto = "0.17.0" | ||
| mpc-recovery = { path = "../mpc-recovery" } | ||
| rand = "0.8.4" | ||
| log = "0.4" |
There was a problem hiding this comment.
Not a huge deal, but we don't use log in other crates, we use tracing instead
There was a problem hiding this comment.
Good point. Done.
| .register_transaction( | ||
| transaction!(sign) | ||
| .set_sequence(5) | ||
| .set_weight(1000) // In this scenario we are mostly testing /sign functionality |
There was a problem hiding this comment.
What does set_weight actually do here? I would assume that these 5 actions above need to be executed in sequence, so why would we prioritize the last step over the others?
There was a problem hiding this comment.
In the terminal, you are passing a number of users (N) and a scenario (registrationAndSign in this case). Then each user executes transactions in sequence (check .set_sequence(k)). The scenario starts from the beginning after the user ends the previous one.
In these particular load tests we are trying to make as many sign requests as possible. Without .set_weight(1000) sign will be executed once per registration and registration takes several seconds.
itegulov
approved these changes
Oct 23, 2023
Terraform Feature Environment Destroy (dev-325)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.