No delay experiment #512
Merged
No delay experiment #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did we have that 1000ms delay in the first place? |
|
@DavidM-D Without any delay Node will make too many RPC calls. Reading logs on the flight is also a bit easier. |
There was a problem hiding this comment.
Looking at this again, I'm not sure if we should add in this change now, since the protocol state advancement and the triple generation protocol should have separate sleep times. State advancement rarely ever happens so 1s is pretty ideal, meanwhile we want each triple protocol poke to advance much faster than just 1s. How about we do a simple check whether or not the protocol state is in the running state? If it goes from Running to Running state within advance, progress, message.handle then we can set the sleep to be nonexistent, but if we're in the Generating, WaitingForConsensus, Resharing state, we'll have the 1s sleep instead.
Terraform Feature Environment (dev-512)Terraform Initialization ⚙️
|
|
I've changed the design. |
ChaoticTempest
approved these changes
Mar 25, 2024
Terraform Feature Environment Destroy (dev-512)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allowed me to run tests 2 times faster. All the infra setup time is the same, so that is probably 4x+ in performance for the protocol itself. The downside is we will have more requests to RPC.
2 and 100ms are chosen empirically. Gives me the same results as 0 delay.
(tested with 3 nodes, but should help with our scaling problem)