Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use BorshStorageKey for the prefix of LookupMap for pending_requests #608

Merged
merged 1 commit into from
May 27, 2024
Merged

use BorshStorageKey for the prefix of LookupMap for pending_requests #608

merged 1 commit into from
May 27, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented May 22, 2024 •
edited
Loading

mentioned in this issue: #579

@ppca ppca requested review from volovyks and ChaoticTempest May 22, 2024 08:53
@ppca ppca linked an issue May 22, 2024 that may be closed by this pull request
Consider using BorshStorageKey to allow for iterative upgrades/migrations #579
Closed
volovyks
volovyks previously approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
FYI, we will need to reset the request counter after deploying this update.

@ppca ppca force-pushed the xiangyi/BorshStorageKey branch from 4f37709 to a5e91f0 Compare May 24, 2024 08:00
@ppca ppca requested a review from volovyks May 24, 2024 08:01
@volovyks volovyks merged commit 653f4e1 into develop May 27, 2024
4 of 5 checks passed
@volovyks volovyks deleted the xiangyi/BorshStorageKey branch May 27, 2024 12:17
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-608)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticTempest ChaoticTempest ChaoticTempest approved these changes

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using BorshStorageKey to allow for iterative upgrades/migrations
3 participants
@ppca @volovyks @ChaoticTempest