Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add port to my_address so join method works #612

Merged
merged 2 commits into from
May 27, 2024
Merged

fix: add port to my_address so join method works #612

merged 2 commits into from
May 27, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented May 24, 2024

No description provided.

@ppca ppca requested review from volovyks and ChaoticTempest May 24, 2024 10:46
@ppca ppca mentioned this pull request May 24, 2024
Closed
@ppca ppca linked an issue May 24, 2024 that may be closed by this pull request
Real env resharing test #573
Closed
volovyks
volovyks previously approved these changes May 24, 2024
View reviewed changes
ChaoticTempest
ChaoticTempest reviewed May 24, 2024
View reviewed changes
node/src/cli.rs Outdated
});
let my_address = my_address
.map(|mut addr| {
let _ = addr.set_port(Some(web_port));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should unwrap and fail early just in case the addr was inputted incorrectly

Suggested change
let _ = addr.set_port(Some(web_port));
addr.set_port(Some(web_port)).unwrap();

@ppca ppca requested a review from ChaoticTempest May 26, 2024 07:43
@volovyks volovyks merged commit 2d8d274 into develop May 27, 2024
3 of 4 checks passed
@volovyks volovyks deleted the xiangyi/fix_new_node_join branch May 27, 2024 14:58
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-612)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticTempest ChaoticTempest ChaoticTempest approved these changes

@volovyks volovyks volovyks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Real env resharing test
3 participants
@ppca @volovyks @ChaoticTempest