Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear triples after reshare #638

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

ChaoticTempest
Copy link
Member

@ChaoticTempest ChaoticTempest commented Jun 8, 2024

We were not clearing our triples from datastore after a reshare, which is required due to there being new participants and potentially older ones no longer existing. The old set of triples would for the most part not be valid and should just cleared. We were already clearing them from memory when we construct a new TripleManager.

Also bins message on TripleIsMissing since that's the case where the node does not have the triple at all due to datastore corruption or was never observed in the system. We won't be able to go into a state where the triple is found so just delete the message.

This can be made more clear with a partitioning of where triples are stored https://github.com/near/transfer/issues/30. Which would allow us to serve signatures beyond the resharing phase if we'd like not to clear triples and maintain a separate network for a bit

@ChaoticTempest ChaoticTempest merged commit 1b2b49f into develop Jun 11, 2024
3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/fix/clear-triples-after-reshare branch June 11, 2024 23:10
Copy link

Terraform Feature Environment Destroy (dev-638)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants