Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not clearing our triples from datastore after a reshare, which is required due to there being new participants and potentially older ones no longer existing. The old set of triples would for the most part not be valid and should just cleared. We were already clearing them from memory when we construct a new
TripleManager
.Also bins message on
TripleIsMissing
since that's the case where the node does not have the triple at all due to datastore corruption or was never observed in the system. We won't be able to go into a state where the triple is found so just delete the message.This can be made more clear with a partitioning of where triples are stored https://github.com/near/transfer/issues/30. Which would allow us to serve signatures beyond the resharing phase if we'd like not to clear triples and maintain a separate network for a bit