Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerfile multichain #648

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix: dockerfile multichain #648

merged 3 commits into from
Jun 14, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented Jun 14, 2024

Has been broken since we change folder structure. already tested on develop this works.
This will fix the down dev env.

There were 2 bugs with the Dockerfile.multichain:

  1. we copied whole mpc folder instead of chain-signatures/ folder. the issue there is the top level mpc folder has no Cargo.toml file, nothing will be built;
  2. after fixing 1), I find that https://github.com/near/mpc/blob/develop/chain-signatures/.cargo/config.toml#L2 actually ask to put the built binary to ../target, instead of target. But later when we do
    COPY --from=builder /usr/src/app/target/release/mpc-recovery-node /usr/local/bin/mpc-recovery-node
    it is copying from target instead of ../target. Which will copy nothing

This can be verified by built artifact size. If you look at artifacts size: correct ones are 60+mb, incorrect ones are only 50+ mb. I think reflects the fact that actually nothing is built.

Also included a dependency fix. Because the dmd/bump-dependencies branch has been deleted, I updated to a commit hash that merged.

@ppca ppca changed the title fix dockerfile multichain fix: dockerfile multichain Jun 14, 2024
@ppca ppca requested a review from ailisp June 14, 2024 18:50
Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ppca ppca merged commit b4d5234 into develop Jun 14, 2024
3 checks passed
@ppca ppca deleted the xiangyi/fix_dockerfile_multichain branch June 14, 2024 18:58
Copy link

Terraform Feature Environment Destroy (dev-648)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ppca, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants