-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: contract init stuck because of secret storage loading #668
Conversation
1
failed node state progressif let Ok(persistent_node_data) = serde_json::from_slice(&data) { | ||
Ok(Some(persistent_node_data)) | ||
} else { | ||
tracing::info!("failed to convert stored data to key share, presuming it is missing"); | ||
Ok(None) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should log the error just in case so we can debug what the exact cause was. We shouldn't include the actual data
portion itself but should include things like the length of it just in case we made some incompatible version serialization changes to persistent node data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point on the case of debugging. I suggest to make the log level to warn. Current log information should be sufficient to debug (timestamp, node config's sk_share_secret_id), make it to warn maybe easier to track unexpected case in monitor.
Terraform Feature Environment Destroy (dev-668)Terraform Initialization ⚙️
|
secret storage loading value
1
, which is the initial value, returns error instead of None, thus state progression is stuck