chore: cleaning up message protocol for better consistency #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
reviewed
Jul 17, 2024
| } | ||
|
|
||
| // if triple id is in GC, remove this triple message because the triple is currently | ||
| // being GC'ed, where the triple protocol has previously failed or been utilized. |
There was a problem hiding this comment.
garbage collection
ppca
approved these changes
Jul 18, 2024
Terraform Feature Environment Destroy (dev-686)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanups our message processing loop. No more pesky leftover messages in our logs since they really were not necessary at all. This makes cleaning up triples, presignatures and signatures that have either been completed, failed or taken much more consistently.