contract: add my_derived_public_key() #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chain-signatures/contract/src/lib.rs
Outdated
| @@ -373,6 +374,19 @@ impl VersionedMpcContract { | |||
| } | |||
| } | |||
|
|
|||
| /// This is the derived key given path | |||
| pub fn my_derived_public_key(&self, path: String) -> PublicKey { | |||
There was a problem hiding this comment.
Don't think my adds any more info here, and we should just keep consistent with verbs in contract interfaces. How about we just rename to derive_public_key
There was a problem hiding this comment.
changed it to derived_public_key() to be consistent with public_key()
ChaoticTempest
previously approved these changes
Jul 18, 2024
chain-signatures/contract/src/lib.rs
Outdated
Comment on lines
378
to
379
| pub fn derived_public_key(&self, path: String) -> PublicKey { | ||
| let predecessor = env::predecessor_account_id(); |
There was a problem hiding this comment.
I think we should add in an option where people can specify the predecessor account id since the one calling this function might or might not be the right one. Like in this case:
user.near calls nft.near
nft.near calls sign
predecessor_id = nft.near
user.near calls derived_public_key
predecessor_id = user.near
Suggested change
| pub fn derived_public_key(&self, path: String) -> PublicKey { | |
| let predecessor = env::predecessor_account_id(); | |
| pub fn derived_public_key(&self, path: String, predecessor: Option<AccountId>) -> PublicKey { | |
| let predecessor = predecessor.unwrap_or_else(env::predecessor_account_id); |
ChaoticTempest
approved these changes
Jul 18, 2024
Terraform Feature Environment Destroy (dev-691)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.