Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to sha3 for the KDF #701

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Migrate to sha3 for the KDF #701

merged 6 commits into from
Jul 19, 2024

Conversation

DavidM-D
Copy link
Contributor

@DavidM-D DavidM-D commented Jul 19, 2024 •
edited
Loading

From the audit, not completely convinced that it's necessary, but better to be safe than sorry.

@DavidM-D DavidM-D changed the title #700 Migrate to sha3 #700 Migrate to sha3 for the KDF Jul 19, 2024
@DavidM-D DavidM-D linked an issue Jul 19, 2024 that may be closed by this pull request
KS–PCS–F–4 Use of SHA2 as a KDF #700
Closed
@DavidM-D DavidM-D changed the title #700 Migrate to sha3 for the KDF Migrate to sha3 for the KDF Jul 19, 2024
@DavidM-D DavidM-D requested a review from volovyks July 19, 2024 11:16
volovyks
volovyks previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volovyks volovyks merged commit 3248deb into develop Jul 19, 2024
3 checks passed
@volovyks volovyks deleted the dmd/sha3-kdf branch July 19, 2024 15:14
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-701)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KS–PCS–F–4 Use of SHA2 as a KDF
2 participants
@DavidM-D @volovyks