Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add latest_block_height and is_stable to /state; only stable nodes can partake in signature generation #710

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

ChaoticTempest
Copy link
Member

This adds in the latest_block_height and is_stable values to StateView so a node can keep track whether a connection is stable or not. A node will only consider another node to be able to generate a signature if and only if it is stable, such as when it is caught up with indexed blocks. This only affects signature generation, so things like triples, presginatures, resharing are still fine even if a node is not stable.

This fixes #680 partially but only handles the honest node portion.

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I was expecting that nodes would fetch other nodes' states and decide if they are active by themselves, but that approach has its downsides too.

chain-signatures/node/src/indexer.rs Show resolved Hide resolved
@ChaoticTempest ChaoticTempest merged commit 044c05f into develop Jul 23, 2024
3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/feat/state-tracks-block-height branch July 23, 2024 18:17
Copy link

Terraform Feature Environment Destroy (dev-710)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include node heights metric in the liveliness of a node
2 participants