Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make PresignatureId be generated and reproducible from triple ids #752

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ChaoticTempest
Copy link
Member

This is better to have now than later, as we won't break the presignature id guarantees later if we add it later.

This will allow us to validate Presignature generation messages a lit bit more easily by verifying that the presignature id is correct in the future

hasher.update(triple1.to_le_bytes());
let seed: [u8; 32] = hasher.finalize().into();
let mut rng = StdRng::from_seed(seed);
let id = rng.gen::<u64>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just pick first 8 byte of the [u8; 32] as u64 id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that also works. Either could work, but I guess that one doesn't rely on RNG. Will change it to not use RNG

ailisp
ailisp previously approved these changes Jul 29, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement!

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
test_multichain_reshare_with_lake_congestion test is unstable :/ cc @ailisp I do not think that this is fault of the test. Probably we need to fix it on the node some day.

@ChaoticTempest ChaoticTempest merged commit 7a0d45c into develop Jul 29, 2024
3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/feat/make-presignature-id-reproducible branch July 29, 2024 18:28
Copy link

Terraform Feature Environment Destroy (dev-752)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants