Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the signature cost public #761

Closed
wants to merge 1 commit into from
Closed

Make the signature cost public #761

wants to merge 1 commit into from

Conversation

DavidM-D
Copy link
Contributor

No description provided.

@DavidM-D DavidM-D requested a review from volovyks July 30, 2024 08:35
volovyks
volovyks reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The price will not be guaranteed to stay the same during the sign() call.

chain-signatures/contract/src/lib.rs
@@ -790,7 +790,7 @@ impl VersionedMpcContract {
}
}

fn signature_deposit(&self) -> u128 {
pub fn signature_deposit(&self) -> u128 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's public - it needs to moved to our public impl block for better visibility.

@volovyks
Copy link
Collaborator

Closing in favor of #782

@volovyks volovyks closed this Jul 31, 2024
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-761)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidM-D @volovyks