Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup jsonrpc client in integration tests #828

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

ChaoticTempest
Copy link
Member

We don't need to use jsonrpc-client separately anymore since near_fetch::Client is quite feature rich now and can directly do everything more cleanly there

}))
.max_gas()
.deposit(NearToken::from_yoctonear(1))
.transact_async()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice enhancement, i've seen concurrent tests fail due to invalid nonce

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah hopefully this resolves that a bit. It won't retry though since near-fetch requires explicit .retry_expoential(...)

ailisp
ailisp previously approved these changes Sep 4, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ChaoticTempest ChaoticTempest force-pushed the phuong/chore/cleanup-jsonrpc-client branch from 0a83e67 to a74c620 Compare September 5, 2024 06:31
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor

@ChaoticTempest ChaoticTempest merged commit 619aeb1 into develop Sep 5, 2024
3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/chore/cleanup-jsonrpc-client branch September 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants