add timeout to requests to nodes and add metric for iter cnts #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
volovyks
reviewed
Oct 10, 2024
| @@ -398,6 +398,15 @@ pub(crate) static SIGNATURE_PUBLISH_RESPONSE_ERRORS: Lazy<CounterVec> = Lazy::ne | |||
| .unwrap() | |||
| }); | |||
|
|
|||
| pub(crate) static PROTOCOL_LATENCY_ITER_CNT: Lazy<CounterVec> = Lazy::new(|| { | |||
| try_create_counter_vec( | |||
There was a problem hiding this comment.
Do you want to measure latency or count iterations? Let's rename this accordingly and use counter if it's the later one.
ChaoticTempest
previously approved these changes
Oct 10, 2024
That is a timeout, if the request finish before 5s, it will return much sooner than 5s. So it unstuck when /msg is not available, and it will be as fast if /msg is working properly. |
volovyks
approved these changes
Oct 10, 2024
kmaus-near
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.