fix: make sure that the flow works when params/result are missing

near · Jan 25, 2023 · 7c7370d · 7c7370d
1 parent 38ac5bc
commit 7c7370d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/near-api-js/src/contract.ts b/packages/near-api-js/src/contract.ts
@@ -19,15 +19,15 @@ function nameFunction(name: string, body: (args?: any[]) => any) {
 function validateArguments(args: object, abiFunction: AbiFunction, ajv: Ajv, abiRoot: AbiRoot) {
     if (!isObject(args)) return;
 
-    if (abiFunction.params?.serialization_type !== AbiSerializationType.Json) {
+    if (abiFunction.params && abiFunction.params.serialization_type !== AbiSerializationType.Json) {
         throw new UnsupportedSerializationError(abiFunction.name, abiFunction.params.serialization_type);
     }
 
-    if (abiFunction.result?.serialization_type !== AbiSerializationType.Json) {
-        throw new UnsupportedSerializationError(abiFunction.name, abiFunction.params.serialization_type);
+    if (abiFunction.result && abiFunction.result.serialization_type !== AbiSerializationType.Json) {
+        throw new UnsupportedSerializationError(abiFunction.name, abiFunction.result.serialization_type);
     }
 
-    const params = abiFunction.params.args;
+    const params = abiFunction.params?.args || [];
     for (const p of params) {
         const arg = args[p.name];
         const typeSchema = p.type_schema;

diff --git a/packages/near-api-js/test/contract_abi.test.js b/packages/near-api-js/test/contract_abi.test.js
@@ -60,6 +60,10 @@ let rawAbi = `{
             "$ref": "#/definitions/Pair"
           }
         }
+      },
+      {
+        "name": "empty_call",
+        "kind": "call"
       }
     ],
     "root_schema": {
@@ -141,6 +145,12 @@ describe('add_call', () => {
     });
 });
 
+describe('empty_call', () => {
+    test('can be called successfully', async () => {
+        await contract.empty_call({});
+    });
+});
+
 describe('Contract constructor', () => {
     test('throws UnsupportedSerializationError when ABI has borsh serialization', async () => {
         let rawAbi = `{