Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a better wallet_auth_key prefix #325

Closed
amgando opened this issue May 19, 2020 · 3 comments · Fixed by #1014
Closed

provide a better wallet_auth_key prefix #325

amgando opened this issue May 19, 2020 · 3 comments · Fixed by #1014
Assignees
Labels
devx enhancement New feature or request icebox P3 Nice to have. (Realistically we're not going to do this...)

Comments

@amgando
Copy link
Contributor

amgando commented May 19, 2020

currently wallet uses a user-defined prefix for the key in LocalStorage

note:

undefined_ wallet_auth_key

 {
 "undefined_wallet_auth_key": 

 {"accountId":"sherif-demo.testnet","allKeys":["ed25519:Azqg7VBLGYo8LdiJ4SEzgodg3JXANoJm8jbH1homoVj6"]} 

}

this could be improved with a more friendly default value for appKeyPrefix

const authDataKey = appKeyPrefix + LOCAL_STORAGE_KEY_SUFFIX;

@amgando amgando added enhancement New feature or request P3 Nice to have. (Realistically we're not going to do this...) devx labels May 26, 2020
@mikedotexe
Copy link
Contributor

@stefanopepe does this sound like a change that will break Wallet or have concerns with this?

@stefanopepe
Copy link

@stefanopepe does this sound like a change that will break Wallet or have concerns with this?

We are re-designing the key management, and we'll start working on it in the next sprint. The UX will probably include a way for the user to append notes/memorable information to each key, but I don't have more information to share right now.

Roping in @MaximusHaximus for an estimation of the changes

@MaximusHaximus
Copy link
Contributor

I did an audit, and I don't believe that we reference this _wallet_auth_key localstorage value anywhere in the wallet codebase directly. As a result, as long as long as near-api-js handles backwards compatibility internally for anything that relies on it in near-api-js, it shouldn't have any impact on the wallet as far as I can tell. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx enhancement New feature or request icebox P3 Nice to have. (Realistically we're not going to do this...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants