Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make appKeyPrefix required #1014

Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat!: make appKeyPrefix required #1014

merged 2 commits into from
Jan 5, 2023

Conversation

esaminu
Copy link
Contributor

@esaminu esaminu commented Oct 11, 2022

Motivation

Alternative approach to key migration implemented in #947 . Closes #325

Description

Makes appKeyPrefix a required arg to WalletConnection constructor

Users that were doing

new WalletConnection(near);

will now have to do

new WalletConnection(near, "undefined");

If they want to access the keys they had potentially accumulated

Checklist

  • Read the contributing guidelines
  • Commit messages follow the conventional commits spec
  • Performed a self-review of the PR
  • Added automated tests
  • Manually tested the change

@esaminu esaminu requested a review from andy-haynes October 11, 2022 12:30
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: 5dfc00a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
near-api-js Major
@near-js/cookbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andy-haynes andy-haynes merged commit abb2d19 into master Jan 5, 2023
@andy-haynes andy-haynes deleted the naj-109-1 branch January 5, 2023 22:48
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a better wallet_auth_key prefix
2 participants